| Summary: | Preview popover needs minimum and maximum sizes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bdakin, commit-queue, conrad_shultz, thorton | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Beth Dakin
2014-11-20 16:47:16 PST
Created attachment 242009 [details]
Patch
Attachment 242009 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:398: Missing space after , [whitespace/comma] [3]
ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:405: Missing space after , [whitespace/comma] [3]
Total errors found: 2 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 242009 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242009&action=review > Source/WebKit2/ChangeLog:12 > + _hitTestResult, so we should computer a new origin rect based on the original computer!! > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:398 > + if (targetSizeFitsInAvailableSpace(targetSize, maxSpaceAvailableOnYEdge) && targetSizeFitsInAvailableSpace(targetSize,largestPopoverSize)) you're missing some spaces after your commas Thank you! http://trac.webkit.org/changeset/176429 Comment on attachment 242009 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242009&action=review > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:363 > + NSSize screenSize = [[NSScreen mainScreen] frame].size; I'm not sure this will do what you want in all multi-screen cases. Is it guaranteed that keyboard focus is on the same screen as the presenting WKView? http://trac.webkit.org/changeset/176430 Good call, Conrad! |