Bug 138943 – Preview popover needs minimum and maximum sizes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Beth Dakin]

Preview popover needs minimum and maximum sizes

rdar://problem/18904651

[Beth Dakin]

Created attachment 242009 [details]
Patch

[WebKit Commit Bot]

Attachment 242009 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:398:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:405:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 242009 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242009&action=review

> Source/WebKit2/ChangeLog:12
> +        _hitTestResult, so we should computer a new origin rect based on the original 

computer!!

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:398
> +    if (targetSizeFitsInAvailableSpace(targetSize, maxSpaceAvailableOnYEdge) && targetSizeFitsInAvailableSpace(targetSize,largestPopoverSize))

you're missing some spaces after your commas

[Beth Dakin]

Thank you! http://trac.webkit.org/changeset/176429

[Conrad Shultz]

Comment on attachment 242009 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242009&action=review

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:363
> +    NSSize screenSize = [[NSScreen mainScreen] frame].size;

I'm not sure this will do what you want in all multi-screen cases. Is it guaranteed that keyboard focus is on the same screen as the presenting WKView?

[Beth Dakin]

http://trac.webkit.org/changeset/176430 Good call, Conrad!