Bug 138932

Summary: Add parsing for :dir()
Product: WebKit Reporter: Sukolsak Sakshuwong <sukolsak>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, sukolsak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sukolsak Sakshuwong
Reported 2014-11-20 13:41:35 PST
See http://dev.w3.org/csswg/selectors4/#the-dir-pseudo
Attachments
Patch (17.46 KB, patch)
2014-11-20 13:52 PST, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Patch (17.49 KB, patch)
2014-11-25 01:54 PST, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sukolsak Sakshuwong
Comment 1 2014-11-20 13:52:35 PST
Created attachment 241977 [details] Patch
Benjamin Poulain
Comment 2 2014-11-25 01:20:40 PST
Comment on attachment 241977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241977&action=review Everything looks good. The tests are great. > Source/WebCore/css/CSSGrammar.y.in:67 > case MATCHESFUNCTION: Hum, you'll need to update before landing, I moved this one.
Sukolsak Sakshuwong
Comment 3 2014-11-25 01:54:45 PST
Created attachment 242190 [details] Patch
Benjamin Poulain
Comment 4 2014-11-25 15:50:23 PST
Comment on attachment 242190 [details] Patch Let's land!
WebKit Commit Bot
Comment 5 2014-11-25 16:27:36 PST
Comment on attachment 242190 [details] Patch Clearing flags on attachment: 242190 Committed r176545: <http://trac.webkit.org/changeset/176545>
WebKit Commit Bot
Comment 6 2014-11-25 16:27:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.