Bug 138923

Summary: Rename String.prototype.contains to String.prototype.includes
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, fpizlo, ggaren, kling, mark.lam, mathias, msaboff, oliver, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Yusuke Suzuki
Reported 2014-11-20 02:22:27 PST
Rename String.prototype.contains to String.prototype.includes
Attachments
Patch (41.77 KB, patch)
2014-11-20 02:29 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2014-11-20 02:29:03 PST
Created attachment 241937 [details] Patch
Yusuke Suzuki
Comment 2 2014-11-20 02:38:41 PST
Change in V8: https://codereview.chromium.org/742963002
Geoffrey Garen
Comment 3 2014-11-20 10:12:59 PST
Comment on attachment 241937 [details] Patch r=me
Yusuke Suzuki
Comment 4 2014-11-20 10:20:45 PST
(In reply to comment #3) > Comment on attachment 241937 [details] > Patch > > r=me Thank you for your review :)
WebKit Commit Bot
Comment 5 2014-11-20 10:50:50 PST
Comment on attachment 241937 [details] Patch Clearing flags on attachment: 241937 Committed r176404: <http://trac.webkit.org/changeset/176404>
WebKit Commit Bot
Comment 6 2014-11-20 10:50:55 PST
All reviewed patches have been landed. Closing bug.
Yusuke Suzuki
Comment 7 2014-11-20 11:01:26 PST
Add additional pointers: https://bugzilla.mozilla.org/show_bug.cgi?id=1102219
Benjamin Poulain
Comment 8 2014-11-20 11:22:05 PST
Aww, I liked String.contains better :(
Note You need to log in before you can comment on or make changes to this bug.