Bug 138910

Summary:

New perf dashboard should provide UI to create a new analysis task

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Perf Dashboard

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, benjamin, cdumez, kling, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

138516

Attachments:

Description	Flags
Patch	benjamin: review+

Description Ryosuke Niwa 2014-11-19 20:36:07 PST

Now that we've added the UI to see an analysis task in the bug 138517,
we should also add the UI to create one.

Comment 1 Ryosuke Niwa 2014-11-19 21:13:25 PST

Created attachment 241926 [details]
Patch

Comment 2 Benjamin Poulain 2014-11-20 14:49:13 PST

Comment on attachment 241926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241926&action=review

rs=me

> Websites/perf.webkit.org/public/v2/app.js:1312
> +        if (!offset || !$(event.target).closest('svg').length)

closest! :)

> Websites/perf.webkit.org/public/v2/app.js:1452
> +                return (+firstPoint.time + +secondPoint.time) / 2;

Are all the "+" intended?

Comment 3 Ryosuke Niwa 2014-11-20 14:53:04 PST

Comment on attachment 241926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241926&action=review

>> Websites/perf.webkit.org/public/v2/app.js:1452
>> +                return (+firstPoint.time + +secondPoint.time) / 2;
> 
> Are all the "+" intended?

Yes, I need to convert them to integer first.

Comment 4 Ryosuke Niwa 2014-11-20 15:24:54 PST

Committed r176422: <http://trac.webkit.org/changeset/176422>