Bug 138868

Summary: [GTK] Error in documentation of webkit_print_operation_get_page_setup()
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: berto, cgarcia, commit-queue, gns, mcatanzaro, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Description Michael Catanzaro 2014-11-19 05:33:27 PST
The documentation for webkit_print_operation_get_page_setup() says:

"Return the current page setup of print_operation . It returns NULL until either webkit_print_operation_set_print_settings() or webkit_print_operation_run_dialog() have been called."

That should refer to webkit_print_operation_set_page_setup(), not webkit_print_operation_set_print_settings().

Reported at https://lists.webkit.org/pipermail/webkit-gtk/2014-November/002148.html
Comment 1 Michael Catanzaro 2014-11-19 05:36:47 PST
Created attachment 241855 [details]
Patch
Comment 2 WebKit Commit Bot 2014-11-19 05:37:52 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 WebKit Commit Bot 2014-11-19 06:24:06 PST
Comment on attachment 241855 [details]
Patch

Clearing flags on attachment: 241855

Committed r176316: <http://trac.webkit.org/changeset/176316>
Comment 4 WebKit Commit Bot 2014-11-19 06:24:10 PST
All reviewed patches have been landed.  Closing bug.