RESOLVED FIXED 138868
[GTK] Error in documentation of webkit_print_operation_get_page_setup() 
https://bugs.webkit.org/show_bug.cgi?id=138868
Summary [GTK] Error in documentation of webkit_print_operation_get_page_setup()
Michael Catanzaro
Reported 2014-11-19 05:33:27 PST
The documentation for webkit_print_operation_get_page_setup() says: "Return the current page setup of print_operation . It returns NULL until either webkit_print_operation_set_print_settings() or webkit_print_operation_run_dialog() have been called." That should refer to webkit_print_operation_set_page_setup(), not webkit_print_operation_set_print_settings(). Reported at https://lists.webkit.org/pipermail/webkit-gtk/2014-November/002148.html
Attachments
Patch (1.60 KB, patch)
2014-11-19 05:36 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2014-11-19 05:36:47 PST
Created attachment 241855 [details] Patch
WebKit Commit Bot
Comment 2 2014-11-19 05:37:52 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 3 2014-11-19 06:24:06 PST
Comment on attachment 241855 [details] Patch Clearing flags on attachment: 241855 Committed r176316: <http://trac.webkit.org/changeset/176316>
WebKit Commit Bot
Comment 4 2014-11-19 06:24:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.