Bug 138868 - [GTK] Error in documentation of webkit_print_operation_get_page_setup()
Summary: [GTK] Error in documentation of webkit_print_operation_get_page_setup()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-19 05:33 PST by Michael Catanzaro
Modified: 2014-11-19 06:24 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2014-11-19 05:36 PST, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2014-11-19 05:33:27 PST 
The documentation for webkit_print_operation_get_page_setup() says:

"Return the current page setup of print_operation . It returns NULL until either webkit_print_operation_set_print_settings() or webkit_print_operation_run_dialog() have been called."

That should refer to webkit_print_operation_set_page_setup(), not webkit_print_operation_set_print_settings().

Reported at https://lists.webkit.org/pipermail/webkit-gtk/2014-November/002148.html
Comment 1 Michael Catanzaro 2014-11-19 05:36:47 PST 
Created attachment 241855 [details]
Patch
Comment 2 WebKit Commit Bot 2014-11-19 05:37:52 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 WebKit Commit Bot 2014-11-19 06:24:06 PST 
Comment on attachment 241855 [details]
Patch

Clearing flags on attachment: 241855

Committed r176316: <http://trac.webkit.org/changeset/176316>
Comment 4 WebKit Commit Bot 2014-11-19 06:24:10 PST 
All reviewed patches have been landed.  Closing bug.