Summary: | [GStreamer] Timeline scrubber not updating as the video plays | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Xabier Rodríguez Calvar <calvaris> | ||||
Component: | WebCore Misc. | Assignee: | Enrique Ocaña <eocanha> | ||||
Status: | RESOLVED INVALID | ||||||
Severity: | Normal | CC: | bugs-noreply, buildbot, calvaris, commit-queue, dino, eocanha, eric.carlson, ews-watchlist, glenn, jer.noble, joepeck, mcatanzaro, philipj, rniwa, sergio | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 138717 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Xabier Rodríguez Calvar
2014-11-17 00:00:16 PST
Created attachment 389800 [details]
Patch
Comment on attachment 389800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389800&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsBase.js:408 > + this.controls.panel.classList.remove(this.ClassNames.hidden); Always remove hidden before adding show. > Source/WebCore/Modules/mediacontrols/mediaControlsBase.js:1027 > + this.controls.panel.classList.remove(this.ClassNames.hidden); Always remove hidden before adding show. > Source/WebCore/Modules/mediacontrols/mediaControlsBase.js:1035 > + this.controls.panel.classList.add(this.ClassNames.hidden); When you do this, you remove the fade out animation of the controls. With this they disappear immediately. The idea here is to remove the show and once the fade out animation is done, we add the hidden in handlePanelTransitionEnd. Could your problem be that handlePanelTransitionEnd is not being called for some reason? You can try any HTML5 pure video and you'll notice the difference. Thanks for noticing that I was breaking the fade out animation. After more learning and debugging, I realized that the html webpage with a <video> tag on which I was experiencing the issue of "the video controls never dissapearing and time not advancing" had some custom styles that were causing the issue only for that page. Everything works fine in video tags on other webpages. Therefore, the patch I submitted isn't needed. (In reply to Enrique Ocaña from comment #3) > Thanks for noticing that I was breaking the fade out animation. > > After more learning and debugging, I realized that the html webpage with a > <video> tag on which I was experiencing the issue of "the video controls > never dissapearing and time not advancing" had some custom styles that were > causing the issue only for that page. Everything works fine in video tags on > other webpages. > > Therefore, the patch I submitted isn't needed. Should we close this then? Yes, please. |