Bug 138792 - [GStreamer] Timeline scrubber not updating as the video plays
Summary: [GStreamer] Timeline scrubber not updating as the video plays
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrique Ocaña
URL:
Keywords:
Depends on: 138717
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-17 00:00 PST by Xabier Rodríguez Calvar
Modified: 2020-02-10 03:18 PST (History)
15 users (show)

See Also:


Attachments
Patch (52.80 KB, patch)
2020-02-05 06:05 PST, Enrique Ocaña
calvaris: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2014-11-17 00:00:16 PST
We might want to pull this code into the crossplatform file.

+++ This bug was initially created as a clone of Bug #138717 +++

[Media] Timeline scrubber not updating as the video plays
Comment 1 Enrique Ocaña 2020-02-05 06:05:53 PST
Created attachment 389800 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2020-02-06 02:42:53 PST
Comment on attachment 389800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389800&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsBase.js:408
> +        this.controls.panel.classList.remove(this.ClassNames.hidden);

Always remove hidden before adding show.

> Source/WebCore/Modules/mediacontrols/mediaControlsBase.js:1027
> +        this.controls.panel.classList.remove(this.ClassNames.hidden);

Always remove hidden before adding show.

> Source/WebCore/Modules/mediacontrols/mediaControlsBase.js:1035
> +        this.controls.panel.classList.add(this.ClassNames.hidden);

When you do this, you remove the fade out animation of the controls. With this they disappear immediately. The idea here is to remove the show and once the fade out animation is done, we add the hidden in handlePanelTransitionEnd. Could your problem be that handlePanelTransitionEnd is not being called for some reason?

You can try any HTML5 pure video and you'll notice the difference.
Comment 3 Enrique Ocaña 2020-02-07 08:20:50 PST
Thanks for noticing that I was breaking the fade out animation.

After more learning and debugging, I realized that the html webpage with a <video> tag on which I was experiencing the issue of "the video controls never dissapearing and time not advancing" had some custom styles that were causing the issue only for that page. Everything works fine in video tags on other webpages.

Therefore, the patch I submitted isn't needed.
Comment 4 Xabier Rodríguez Calvar 2020-02-07 08:23:11 PST
(In reply to Enrique Ocaña from comment #3)
> Thanks for noticing that I was breaking the fade out animation.
> 
> After more learning and debugging, I realized that the html webpage with a
> <video> tag on which I was experiencing the issue of "the video controls
> never dissapearing and time not advancing" had some custom styles that were
> causing the issue only for that page. Everything works fine in video tags on
> other webpages.
> 
> Therefore, the patch I submitted isn't needed.

Should we close this then?
Comment 5 Enrique Ocaña 2020-02-07 08:49:37 PST
Yes, please.