| Summary: | Bump EFL version to 1.12.0 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Éva Balázsfalvi <evab.u-szeged> | ||||
| Component: | Tools / Tests | Assignee: | Éva Balázsfalvi <evab.u-szeged> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | gyuyoung.kim, ossy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 138245 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Éva Balázsfalvi
2014-11-14 02:14:10 PST
Created attachment 241568 [details]
Patch
(In reply to comment #1) > Created attachment 241568 [details] > Patch Did you run layout tests and check MiniBrowser? Will it build on x86/ARM/ARM64 too? (In reply to comment #2) > (In reply to comment #1) > > Created attachment 241568 [details] > > Patch > > Did you run layout tests and check MiniBrowser? > Will it build on x86/ARM/ARM64 too? Yes, I did. The build works on all of these platforms, and the MiniBrowser looks good too on some popular sites. and what about layout tests? (In reply to comment #4) > and what about layout tests? I got the same layout test results with the actual and the new EFL too. Thanks, looks good to me. But I let the final review for Gyuyoung, I'm not sure which timing is the best for bump EFL version. Comment on attachment 241568 [details] Patch r176066 fixed a build break with efl 1.12.0. LGTM. Thanks. Comment on attachment 241568 [details] Patch Clearing flags on attachment: 241568 Committed r176196: <http://trac.webkit.org/changeset/176196> All reviewed patches have been landed. Closing bug. |