Bug 138733

Summary: Bump EFL version to 1.12.0
Product: WebKit Reporter: Éva Balázsfalvi <evab.u-szeged>
Component: Tools / TestsAssignee: Éva Balázsfalvi <evab.u-szeged>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 138245    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Éva Balázsfalvi
Reported 2014-11-14 02:14:10 PST
Bump EFL version to 1.12.0
Attachments
Patch (2.20 KB, patch)
2014-11-14 02:18 PST, Éva Balázsfalvi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Éva Balázsfalvi
Comment 1 2014-11-14 02:18:13 PST
Created attachment 241568 [details] Patch
Csaba Osztrogonác
Comment 2 2014-11-14 02:28:11 PST
(In reply to comment #1) > Created attachment 241568 [details] > Patch Did you run layout tests and check MiniBrowser? Will it build on x86/ARM/ARM64 too?
Éva Balázsfalvi
Comment 3 2014-11-14 02:36:46 PST
(In reply to comment #2) > (In reply to comment #1) > > Created attachment 241568 [details] > > Patch > > Did you run layout tests and check MiniBrowser? > Will it build on x86/ARM/ARM64 too? Yes, I did. The build works on all of these platforms, and the MiniBrowser looks good too on some popular sites.
Csaba Osztrogonác
Comment 4 2014-11-14 03:08:10 PST
and what about layout tests?
Éva Balázsfalvi
Comment 5 2014-11-14 03:38:24 PST
(In reply to comment #4) > and what about layout tests? I got the same layout test results with the actual and the new EFL too.
Csaba Osztrogonác
Comment 6 2014-11-14 05:54:21 PST
Thanks, looks good to me. But I let the final review for Gyuyoung, I'm not sure which timing is the best for bump EFL version.
Gyuyoung Kim
Comment 7 2014-11-16 22:53:49 PST
Comment on attachment 241568 [details] Patch r176066 fixed a build break with efl 1.12.0. LGTM. Thanks.
Éva Balázsfalvi
Comment 8 2014-11-17 01:53:31 PST
Comment on attachment 241568 [details] Patch Clearing flags on attachment: 241568 Committed r176196: <http://trac.webkit.org/changeset/176196>
Éva Balázsfalvi
Comment 9 2014-11-17 01:53:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.