Bug 138733 - Bump EFL version to 1.12.0
Summary: Bump EFL version to 1.12.0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Éva Balázsfalvi
URL:
Keywords:
Depends on: 138245
Blocks:
  Show dependency tree / graph
 
Reported: 2014-11-14 02:14 PST by Éva Balázsfalvi
Modified: 2014-11-17 01:53 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.20 KB, patch)
2014-11-14 02:18 PST, Éva Balázsfalvi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Éva Balázsfalvi 2014-11-14 02:14:10 PST 
Bump EFL version to 1.12.0
Comment 1 Éva Balázsfalvi 2014-11-14 02:18:13 PST 
Created attachment 241568 [details]
Patch
Comment 2 Csaba Osztrogonác 2014-11-14 02:28:11 PST 
(In reply to comment #1)
> Created attachment 241568 [details]
> Patch

Did you run layout tests and check MiniBrowser?
Will it build on x86/ARM/ARM64 too?
Comment 3 Éva Balázsfalvi 2014-11-14 02:36:46 PST 
(In reply to comment #2)
> (In reply to comment #1)
> > Created attachment 241568 [details]
> > Patch
> 
> Did you run layout tests and check MiniBrowser?
> Will it build on x86/ARM/ARM64 too?

Yes, I did. The build works on all of these platforms, and the MiniBrowser looks good too on some popular sites.
Comment 4 Csaba Osztrogonác 2014-11-14 03:08:10 PST 
and what about layout tests?
Comment 5 Éva Balázsfalvi 2014-11-14 03:38:24 PST 
(In reply to comment #4)
> and what about layout tests?

I got the same layout test results with the actual and the new EFL too.
Comment 6 Csaba Osztrogonác 2014-11-14 05:54:21 PST 
Thanks, looks good to me. But I let the final review for Gyuyoung,
I'm not sure which timing is the best for bump EFL version.
Comment 7 Gyuyoung Kim 2014-11-16 22:53:49 PST 
Comment on attachment 241568 [details]
Patch

r176066 fixed a build break with efl 1.12.0. LGTM. Thanks.
Comment 8 Éva Balázsfalvi 2014-11-17 01:53:31 PST 
Comment on attachment 241568 [details]
Patch

Clearing flags on attachment: 241568

Committed r176196: <http://trac.webkit.org/changeset/176196>
Comment 9 Éva Balázsfalvi 2014-11-17 01:53:40 PST 
All reviewed patches have been landed.  Closing bug.