Bug 138695

Summary: [SOUP] Use GMainLoopSource for request timeout in ResourceHandle
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, gustavo, rniwa, svillar
Priority: P2 Keywords: Soup
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch svillar: review+

Carlos Garcia Campos
Reported 2014-11-13 04:54:47 PST
We are currently using soup_timeout_add() that simply creates a GSource and attaches it to the given context. Using GMainLoopsource we simplify the code and fix any potential problem of converting the double value into milliseconds.
Attachments
Patch (4.87 KB, patch)
2014-11-13 04:56 PST, Carlos Garcia Campos 		svillar: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-11-13 04:56:42 PST
Created attachment 241482 [details] Patch
Carlos Garcia Campos
Comment 2 2014-11-14 01:21:52 PST
Committed r176120: <http://trac.webkit.org/changeset/176120>
Note You need to log in before you can comment on or make changes to this bug.