Bug 138681

Summary: Create canonical lists of registers used by both the Assemblers and the JIT probes
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, fpizlo, ggaren, msaboff, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 138671    
Attachments:
Description Flags
the patch. fpizlo: review+

Mark Lam
Reported 2014-11-12 18:04:19 PST
Currently they used 2 separate but parallel lists. The 2 shall become 1.
Attachments
the patch. (14.01 KB, patch)
2014-11-12 18:13 PST, Mark Lam 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2014-11-12 18:13:56 PST
Created attachment 241461 [details] the patch.
WebKit Commit Bot
Comment 2 2014-11-12 18:15:29 PST
Attachment 241461 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/assembler/X86Assembler.h:116: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/X86Assembler.h:118: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/X86Assembler.h:122: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/X86Assembler.h:124: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/ARMAssembler.h:103: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/ARMAssembler.h:105: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/ARMAssembler.h:117: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/ARMAssembler.h:119: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:42: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:50: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:68: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:72: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:107: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:109: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:111: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:112: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:113: One space before end of line comments [whitespace/comments] [5] ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:156: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/ARMv7Assembler.h:158: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] Total errors found: 20 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 3 2014-11-13 08:44:08 PST
Thanks. Landed in r176072: <http://trac.webkit.org/r176072>.
Note You need to log in before you can comment on or make changes to this bug.