Bug 138677

Summary:

Web Inspector: Reduce work when activating multiple agents sequentially

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2014-11-12 15:37:17 PST

* SUMMARY
When activating agents lazily, only do the work in handlers if the current agent is being activated. Otherwise the duplicate work could produce exceptions. E.g. Multiple PageAgent.getResourceTree calls.

Comment 1 Radar WebKit Bug Importer 2014-11-12 15:37:54 PST

<rdar://problem/18962467>

Comment 2 Joseph Pecoraro 2014-11-12 15:38:13 PST

Created attachment 241446 [details]
[PATCH] Proposed Fix

Comment 3 WebKit Commit Bot 2014-11-12 16:27:17 PST

Comment on attachment 241446 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 241446

Committed r176049: <http://trac.webkit.org/changeset/176049>

Comment 4 WebKit Commit Bot 2014-11-12 16:27:21 PST

All reviewed patches have been landed.  Closing bug.