Bug 138664

Summary: Need to show the text indicator when Data Detectors shows a popover
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bdakin: review+

Tim Horton
Reported 2014-11-12 13:16:12 PST
Need to show the text indicator when Data Detectors shows a popover
Attachments
Patch (8.39 KB, patch)
2014-11-12 13:16 PST, Tim Horton 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-11-12 13:16:45 PST
Created attachment 241437 [details] Patch
Tim Horton
Comment 2 2014-11-12 13:17:11 PST
<rdar://problem/18869900>
WebKit Commit Bot
Comment 3 2014-11-12 13:19:01 PST
Attachment 241437 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:57: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:588: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:589: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:591: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:597: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 4 2014-11-12 13:51:01 PST
http://trac.webkit.org/changeset/176037
Tim Horton
Comment 5 2014-11-12 15:25:33 PST
and http://trac.webkit.org/changeset/176044
Note You need to log in before you can comment on or make changes to this bug.