Bug 138640

Summary: Modernize $buildingForIPhone in CodeGeneratorObjC.pm
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: BindingsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, joepeck, mrowe
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2014-11-11 16:39:45 PST
Mac OS X is the only platform that supports NSColor, so rename $buildingForIPhone to $shouldUseCGColor (which is actually what the variable represents) and define it in terms of the "macosx" platform name.
Attachments
Patch v1 (4.02 KB, patch)
2014-11-11 16:43 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2014-11-11 16:43:26 PST
Created attachment 241394 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 2 2014-11-11 16:48:03 PST
<rdar://problem/18919000>
Daniel Bates
Comment 3 2014-11-11 17:06:56 PST
Comment on attachment 241394 [details] Patch v1 OK.
Mark Rowe (bdash)
Comment 4 2014-11-11 17:07:04 PST
Comment on attachment 241394 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=241394&action=review > Source/WebCore/ChangeLog:3 > + Modernize $buildingForIPhone in CodeGeneratorObjC.pm "Modernize" is a strange way of saying "rename".
WebKit Commit Bot
Comment 5 2014-11-11 17:20:35 PST
Comment on attachment 241394 [details] Patch v1 Clearing flags on attachment: 241394 Committed r175995: <http://trac.webkit.org/changeset/175995>
WebKit Commit Bot
Comment 6 2014-11-11 17:20:39 PST
All reviewed patches have been landed. Closing bug.
David Kilzer (:ddkilzer)
Comment 7 2014-11-12 09:35:50 PST
(In reply to comment #4) > Comment on attachment 241394 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=241394&action=review > > > Source/WebCore/ChangeLog:3 > > + Modernize $buildingForIPhone in CodeGeneratorObjC.pm > > "Modernize" is a strange way of saying "rename". That's because it wasn't just a variable rename; I changed the logic of how the variable was defined and removed some cruft.
Note You need to log in before you can comment on or make changes to this bug.