Bug 138639

Summary: Web Inspector: Handle activating extra agents properly after inspector has connected
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: burg, commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
timothy: review+, joepeck: commit-queue-
[PATCH] Rebased Tests none

Joseph Pecoraro
Reported 2014-11-11 15:57:48 PST
* SUMMARY If extra agents are registered after an inspector has connected, they don't get activated. This can be a common scenario when auto-attaching an inspector to a JSContext before that JSContext has had an opportunity to add extra agents.
Attachments
[PATCH] Proposed Fix (8.46 KB, patch)
2014-11-11 15:59 PST, Joseph Pecoraro 		timothy: review+
joepeck: commit-queue-
DetailsFormatted DiffDiff
[PATCH] Rebased Tests (14.47 KB, patch)
2014-11-11 16:21 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-11-11 15:58:02 PST
<rdar://problem/18947710>
Joseph Pecoraro
Comment 2 2014-11-11 15:59:49 PST
Created attachment 241388 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 3 2014-11-11 16:00:52 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Joseph Pecoraro
Comment 4 2014-11-11 16:13:59 PST
Comment on attachment 241388 [details] [PATCH] Proposed Fix Oops, I should rebaseline generated results.
Joseph Pecoraro
Comment 5 2014-11-11 16:21:56 PST
Created attachment 241391 [details] [PATCH] Rebased Tests
WebKit Commit Bot
Comment 6 2014-11-11 19:07:14 PST
Comment on attachment 241391 [details] [PATCH] Rebased Tests Clearing flags on attachment: 241391 Committed r175999: <http://trac.webkit.org/changeset/175999>
WebKit Commit Bot
Comment 7 2014-11-11 19:07:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.