Bug 138624

Summary:

Web Inspector: Main.js missing many trailing semicolons

Product:

WebKit

Reporter:

Jonathan Wells <jonowells>

Component:

Web Inspector

Assignee:

Jonathan Wells <jonowells>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Semicolons added.	none

Description Jonathan Wells 2014-11-11 12:52:10 PST

Semicolons are missing after several function assignments.

Comment 1 Radar WebKit Bug Importer 2014-11-11 12:52:25 PST

<rdar://problem/18944563>

Comment 2 Jonathan Wells 2014-11-11 13:31:59 PST

Created attachment 241379 [details]
[PATCH] Semicolons added.

Comment 3 Joseph Pecoraro 2014-11-11 14:02:35 PST

Comment on attachment 241379 [details]
[PATCH] Semicolons added.

View in context: https://bugs.webkit.org/attachment.cgi?id=241379&action=review

> Source/WebInspectorUI/UserInterface/Base/Main.js:33
> -    Timelines: "timelines",
> +    Timelines: "timelines"

I prefer trailing commas for enums like this. Otherwise diffs end up uglier.

Comment 4 WebKit Commit Bot 2014-11-11 14:20:33 PST

Comment on attachment 241379 [details]
[PATCH] Semicolons added.

Clearing flags on attachment: 241379

Committed r175977: <http://trac.webkit.org/changeset/175977>

Comment 5 WebKit Commit Bot 2014-11-11 14:20:37 PST

All reviewed patches have been landed.  Closing bug.