RESOLVED FIXED 138624
Web Inspector: Main.js missing many trailing semicolons 
https://bugs.webkit.org/show_bug.cgi?id=138624
Summary Web Inspector: Main.js missing many trailing semicolons
Jonathan Wells
Reported 2014-11-11 12:52:10 PST
Semicolons are missing after several function assignments.
Attachments
[PATCH] Semicolons added. (21.91 KB, patch)
2014-11-11 13:31 PST, Jonathan Wells 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-11-11 12:52:25 PST
<rdar://problem/18944563>
Jonathan Wells
Comment 2 2014-11-11 13:31:59 PST
Created attachment 241379 [details] [PATCH] Semicolons added.
Joseph Pecoraro
Comment 3 2014-11-11 14:02:35 PST
Comment on attachment 241379 [details] [PATCH] Semicolons added. View in context: https://bugs.webkit.org/attachment.cgi?id=241379&action=review > Source/WebInspectorUI/UserInterface/Base/Main.js:33 > - Timelines: "timelines", > + Timelines: "timelines" I prefer trailing commas for enums like this. Otherwise diffs end up uglier.
WebKit Commit Bot
Comment 4 2014-11-11 14:20:33 PST
Comment on attachment 241379 [details] [PATCH] Semicolons added. Clearing flags on attachment: 241379 Committed r175977: <http://trac.webkit.org/changeset/175977>
WebKit Commit Bot
Comment 5 2014-11-11 14:20:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.