Bug 138614

Summary: [iOS] cleanup wireless route monitoring
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
jer.noble: review+
Patch for landing. none

Description Eric Carlson 2014-11-11 10:39:27 PST 
Cleanup.
Comment 1 Eric Carlson 2014-11-11 10:39:57 PST 
<rdar://problem/18930328>
Comment 2 Eric Carlson 2014-11-11 10:40:33 PST 
<rdar://problem/18940875>
Comment 3 Eric Carlson 2014-11-11 10:55:45 PST 
Created attachment 241358 [details]
Proposed patch.
Comment 4 WebKit Commit Bot 2014-11-11 10:58:23 PST 
Attachment 241358 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:263:  Use 'WTF::move()' instead of 'std::move()'.  [runtime/wtf_move] [4]
ERROR: Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:264:  Use 'WTF::move()' instead of 'std::move()'.  [runtime/wtf_move] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Jer Noble 2014-11-11 11:01:35 PST 
Comment on attachment 241358 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=241358&action=review

r=me, with nits.

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:239
> +    LOG(Media, "WebMediaSessionHelper::initWithCallback");

Maybe: "-[WebMediaSessionHelper initWithCallback]"?

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:266
>  - (void)dealloc
>  {
> +    LOG(Media, "WebMediaSessionHelper::initWithCallback");

Really? ;)

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:270
> +        auto volumeView = std::move(_volumeView);
> +        auto routingController = std::move(_airPlayPresenceRoutingController);

I think we're supposed to use WTF::move() now.

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:273
> +            LOG(Media, "WebMediaSessionHelper::initWithCallback - dipatched to MainThread");

initWithCallback -> dealloc
Comment 6 Eric Carlson 2014-11-11 11:08:50 PST 
Created attachment 241362 [details]
Patch for landing.
Comment 7 WebKit Commit Bot 2014-11-11 14:03:16 PST 
Comment on attachment 241362 [details]
Patch for landing.

Clearing flags on attachment: 241362

Committed r175976: <http://trac.webkit.org/changeset/175976>