Bug 138602

Summary: DataDetectors' menu items aren't presented in the telephone number menu
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, buildbot, conrad_shultz, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bdakin: review+

Description Tim Horton 2014-11-10 23:30:31 PST
DataDetectors' menu items aren't presented in the telephone number menu
Comment 1 Tim Horton 2014-11-10 23:30:57 PST
Created attachment 241338 [details]
Patch
Comment 2 Tim Horton 2014-11-10 23:31:18 PST
<rdar://problem/18866308>
Comment 3 Conrad Shultz 2014-11-10 23:38:26 PST
Comment on attachment 241338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241338&action=review

> Source/WebKit2/Platform/mac/MenuUtilities.mm:117
> +    return [menu numberOfItems] ? menu : nil;

Did you test whether this check is actually needed? In many cases, an empty NSMenu will behave as if you had no menu at all.
Comment 4 Tim Horton 2014-11-10 23:44:23 PST
(In reply to comment #3)
> Comment on attachment 241338 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=241338&action=review
> 
> > Source/WebKit2/Platform/mac/MenuUtilities.mm:117
> > +    return [menu numberOfItems] ? menu : nil;
> 
> Did you test whether this check is actually needed? In many cases, an empty
> NSMenu will behave as if you had no menu at all.

I did not, and you're probably right. I just translated.
Comment 5 Tim Horton 2014-11-11 12:12:42 PST
http://trac.webkit.org/changeset/175966