Summary: | DataDetectors' menu items aren't presented in the telephone number menu | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bdakin, buildbot, conrad_shultz, rniwa, sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tim Horton
2014-11-10 23:30:31 PST
Created attachment 241338 [details]
Patch
Comment on attachment 241338 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241338&action=review > Source/WebKit2/Platform/mac/MenuUtilities.mm:117 > + return [menu numberOfItems] ? menu : nil; Did you test whether this check is actually needed? In many cases, an empty NSMenu will behave as if you had no menu at all. (In reply to comment #3) > Comment on attachment 241338 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=241338&action=review > > > Source/WebKit2/Platform/mac/MenuUtilities.mm:117 > > + return [menu numberOfItems] ? menu : nil; > > Did you test whether this check is actually needed? In many cases, an empty > NSMenu will behave as if you had no menu at all. I did not, and you're probably right. I just translated. |