Bug 138579

Summary:

Web Inspector: Update Esprima, remove WebInspector.Esprima global.

Product:

WebKit

Reporter:

Jonathan Wells <jonowells>

Component:

Web Inspector

Assignee:

Jonathan Wells <jonowells>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Patch] Suggested fix.	none
[PATCH] Correct esprima version	none
[PATCH] Correct esprima version.	none

Description Jonathan Wells 2014-11-10 14:04:34 PST

Need to remove the WebInspector.Esprima global object. Need to do this for two reasons. First, the combined Esprima.js file (along with all other externals) should be included before Main.js, and thus should be agnostic of the WebInspector. Secondly, from a maintenance standpoint we shouldn't be making changes to this file from the standard Esprima library. The necessary changes to the file could be forgotten in the future, so they shouldn't be done.

Comment 1 Radar WebKit Bug Importer 2014-11-10 14:05:27 PST

<rdar://problem/18931536>

Comment 2 Radar WebKit Bug Importer 2014-11-10 14:05:30 PST

<rdar://problem/18931537>

Comment 3 Jonathan Wells 2014-11-10 15:52:35 PST

Created attachment 241314 [details]
[Patch] Suggested fix.

Comment 4 Joseph Pecoraro 2014-11-10 17:26:51 PST

Comment on attachment 241314 [details]
[Patch] Suggested fix.

View in context: https://bugs.webkit.org/attachment.cgi?id=241314&action=review

> Source/WebInspectorUI/ChangeLog:11
> +        * UserInterface/External/Esprima/esprima.js: File updated, no changes made.

This says "no changes made", yet there are lots and lots of changes. In fact the version went from 1.2.2 to 2.0.0-dev:

    - exports.version = '1.2.2';
    + exports.version = '2.0.0-dev';

Was this intentional? Are there compatibility differences between the versions that we will need to address?

Comment 5 Jonathan Wells 2014-11-10 18:04:58 PST

Created attachment 241324 [details]
[PATCH] Correct esprima version

Pulled incorrect tag before. Here is the correct version: 1.2.2.

Comment 6 Jonathan Wells 2014-11-10 18:06:10 PST

Created attachment 241325 [details]
[PATCH] Correct esprima version.

Comment 7 WebKit Commit Bot 2014-11-10 20:58:28 PST

Comment on attachment 241325 [details]
[PATCH] Correct esprima version.

Clearing flags on attachment: 241325

Committed r175850: <http://trac.webkit.org/changeset/175850>

Comment 8 WebKit Commit Bot 2014-11-10 20:58:31 PST

All reviewed patches have been landed.  Closing bug.