| Summary: | Use std::unique_ptr<> and std::make_unique<> in WebCore | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||
| Component: | WebCore Misc. | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | calvaris, cdumez, commit-queue, darin, eric.carlson, esprehn+autocc, glenn, jer.noble, kangil.han, kondapallykalyan, philipj, sergio, simon.fraser | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 128007 | ||||||||
| Attachments: |
|
||||||||
|
Description
Gyuyoung Kim
2014-11-10 00:03:13 PST
Created attachment 241280 [details]
Patch
Created attachment 241289 [details]
Patch
Attachment 241289 [details] did not pass style-queue:
ERROR: Source/WebCore/dom/ElementIteratorAssertions.h:56: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 241289 [details]
Patch
r=me
Comment on attachment 241289 [details] Patch Clearing flags on attachment: 241289 Committed r175844: <http://trac.webkit.org/changeset/175844> All reviewed patches have been landed. Closing bug. This broke the Windows build: https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29?numbuilds=100 (In reply to comment #7) > This broke the Windows build: > https://build.webkit.org/builders/ > Apple%20Win%20Debug%20%28Build%29?numbuilds=100 Hmm, I need to have time to fix this build error because I don't have win-debug build environment. I'm gonna revert this for now. Reverted r175844 for reason: Win debug build has broken since r175844 Committed r175939: <http://trac.webkit.org/changeset/175939> I took care of these a while back. OwnPtr is almost done now! |