Bug 138553

Summary: [EFL] Remove GamepadDeviceEfl::create()
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Gyuyoung Kim 2014-11-09 19:00:16 PST 
SSIA
Comment 1 Gyuyoung Kim 2014-11-09 19:01:24 PST 
Created attachment 241269 [details]
Patch
Comment 2 Gyuyoung Kim 2014-11-09 21:49:15 PST 
Created attachment 241274 [details]
Patch
Comment 3 Darin Adler 2014-11-09 21:50:20 PST 
Comment on attachment 241274 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241274&action=review

> Source/WebCore/platform/efl/GamepadsEfl.cpp:122
> +    Vector<std::unique_ptr<GamepadDeviceEfl> > m_slots;

No need for the space between the two > characters here.
Comment 4 Gyuyoung Kim 2014-11-09 22:06:24 PST 
Created attachment 241276 [details]
Patch for landing
Comment 5 Gyuyoung Kim 2014-11-09 22:12:10 PST 
(In reply to comment #3)
> Comment on attachment 241274 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=241274&action=review
> 
> > Source/WebCore/platform/efl/GamepadsEfl.cpp:122
> > +    Vector<std::unique_ptr<GamepadDeviceEfl> > m_slots;
> 
> No need for the space between the two > characters here.

Ok, removed it.
Comment 6 WebKit Commit Bot 2014-11-09 22:52:33 PST 
Comment on attachment 241276 [details]
Patch for landing

Clearing flags on attachment: 241276

Committed r175800: <http://trac.webkit.org/changeset/175800>
Comment 7 WebKit Commit Bot 2014-11-09 22:52:36 PST 
All reviewed patches have been landed.  Closing bug.