| Summary: | Context menus should not offer the "Download video" option for videos that cannot be downloaded | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||||
| Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, bdakin, eric.carlson, evab.u-szeged, jer.noble, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Beth Dakin
2014-11-07 17:34:29 PST
Created attachment 241484 [details]
WIP patch
Created attachment 241517 [details]
Patch
I took over this patch from Eric. Eric wanted to write a test, but I don't think it is possible to capture this with a layout test. oncontextmenu will allow you to override the context menu action, but it doesn't let you see what is in the default menu.
I also made one small change that should keep GTK building.
Thanks Tim! http://trac.webkit.org/changeset/176108 *** Bug 138734 has been marked as a duplicate of this bug. *** |