Bug 138505

Summary: Crash playing DASH video
Product: WebKit Reporter: Xavier Claessens <xclaesse>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Relevant valgrind trace
none
Proposed patch none

Xavier Claessens
Reported 2014-11-07 07:58:17 PST
Created attachment 241180 [details] Relevant valgrind trace Webkit2 sometimes crash when playing that video: http://demo.unified-streaming.com/video/smurfs/smurfs.ism/smurfs.mpd?format=mp4 The crash happens when DASH decides to change the video's resolution (it's adaptative). When gstreamer sends caps it means that the NEXT buffer will have that new resolution, but a race can occure and webkit will use that new caps for the PREVIOUS buffer. That lead to a crash because the resolution (thus buffer size) mismatch.
Attachments
Relevant valgrind trace (4.97 KB, text/plain)
2014-11-07 07:58 PST, Xavier Claessens 		no flags
Details
Proposed patch (4.36 KB, patch)
2014-11-07 07:59 PST, Xavier Claessens 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xavier Claessens
Comment 1 2014-11-07 07:59:59 PST
Created attachment 241182 [details] Proposed patch This patch makes sure we always use the GstCaps that goes with the GstBuffer.
Xavier Claessens
Comment 2 2014-11-07 11:30:25 PST
Oops, already fixed. *** This bug has been marked as a duplicate of bug 137065 ***
Note You need to log in before you can comment on or make changes to this bug.