Bug 138505

Summary:

Crash playing DASH video

Product:

WebKit

Reporter:

Xavier Claessens <xclaesse>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Relevant valgrind trace	none
Proposed patch	none

Description Xavier Claessens 2014-11-07 07:58:17 PST

Created attachment 241180 [details]
Relevant valgrind trace

Webkit2 sometimes crash when playing that video: http://demo.unified-streaming.com/video/smurfs/smurfs.ism/smurfs.mpd?format=mp4

The crash happens when DASH decides to change the video's resolution (it's adaptative). When gstreamer sends caps it means that the NEXT buffer will have that new resolution, but a race can occure and webkit will use that new caps for the PREVIOUS buffer. That lead to a crash because the resolution (thus buffer size) mismatch.

Comment 1 Xavier Claessens 2014-11-07 07:59:59 PST

Created attachment 241182 [details]
Proposed patch

This patch makes sure we always use the GstCaps that goes with the GstBuffer.

Comment 2 Xavier Claessens 2014-11-07 11:30:25 PST

Oops, already fixed.

*** This bug has been marked as a duplicate of bug 137065 ***