Bug 138500 – WTR crashes after running a test when NetworkProcess enabled

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff53b0b38 in WebKit::WebNotificationManagerProxy::initializeProvider(WKNotificationProviderBase const*) ()
   from WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
(gdb) bt
#0  0x00007ffff53b0b38 in WebKit::WebNotificationManagerProxy::initializeProvider(WKNotificationProviderBase const*) ()
   from WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#1  0x0000000000418476 in WTR::WebNotificationProvider::~WebNotificationProvider() ()
#2  0x000000000040fc33 in WTR::TestController::~TestController() ()
#3  0x000000000040c250 in main ()

I don't know why it only happens with the network process enabled, though. The thing is that WebNotificationProvider destructor is calling WKNotificationManagerSetProvider, but m_notificationManager is null because removeNotificationManager was already called.

[Carlos Garcia Campos]

Created attachment 241170 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 241170 [details]
Patch

This seems OK to do.

The difference is that on Mac, WebContext is destroyed after WebNotificationProvider, so removeNotificationManager is never called.

[Carlos Garcia Campos]

Committed r175774: <http://trac.webkit.org/changeset/175774>