Bug 138490

Summary: Make it possible to associate snapshots with back/forward list items other than the current item
Product: WebKit Reporter: Anshu Chimala <anshu>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, sam, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
New patch because I missed an UNUSED_PARAM. :( none

Anshu Chimala
Reported 2014-11-06 19:18:54 PST
Currently, WKViews can only save snapshots associated with the current back/forward list item. We should extend this to allow snapshots to be associated with any item in the list. <rdar://problem/18901802>
Attachments
Patch (6.74 KB, patch)
2014-11-07 11:12 PST, Anshu Chimala 		no flags
DetailsFormatted DiffDiff
New patch because I missed an UNUSED_PARAM. :( (6.75 KB, patch)
2014-11-07 11:52 PST, Anshu Chimala 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anshu Chimala
Comment 1 2014-11-07 11:12:03 PST
Created attachment 241194 [details] Patch
Tim Horton
Comment 2 2014-11-07 11:39:25 PST
Looks reasonable to me! Thanks for the patch :)
Anshu Chimala
Comment 3 2014-11-07 11:52:58 PST
Created attachment 241197 [details] New patch because I missed an UNUSED_PARAM. :(
WebKit Commit Bot
Comment 4 2014-11-07 12:35:23 PST
Comment on attachment 241197 [details] New patch because I missed an UNUSED_PARAM. :( Clearing flags on attachment: 241197 Committed r175759: <http://trac.webkit.org/changeset/175759>
WebKit Commit Bot
Comment 5 2014-11-07 12:35:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.