Bug 138485

Summary: Remove useless if check in HTMLInputElement::setValue()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, commit-queue, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2014-11-06 16:31:19 PST
Remove useless if check in HTMLInputElement::setValue().
Attachments
Patch (1.46 KB, patch)
2014-11-06 16:32 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (1.46 KB, patch)
2014-11-06 19:13 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-11-06 16:32:58 PST
Created attachment 241144 [details] Patch
Daniel Bates
Comment 2 2014-11-06 18:11:25 PST
Comment on attachment 241144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241144&action=review > Source/WebCore/html/HTMLInputElement.cpp:-963 > - > - if (!valueChanged) > - return; It looks like this code was inadvertently left in the patch for bug #67742 (http://trac.﷒0﷓), which moved the logic for dispatching change events among other changes from class HTMLInputElement to class InputType or classes that extend InputType. For completeness, this code was originally added in the patch for bug #63092 (http://trac.webkit.org/changeset/89624).
Daniel Bates
Comment 3 2014-11-06 18:13:35 PST
Comment on attachment 241144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241144&action=review > Source/WebCore/ChangeLog:9 > + Remove useless if check in HTMLInputElement::setValue(), probably left > + out after earlier refactoring. For your consideration, I suggest adding a remark that this code was inadvertently left in as part of the patch for bug #67742 (http://trac.webkit.org/changeset/94836). If you feel this is unnecessary then feel free to cq+ this patch.
Chris Dumez
Comment 4 2014-11-06 19:13:44 PST
Created attachment 241155 [details] Patch
WebKit Commit Bot
Comment 5 2014-11-06 21:53:42 PST
Comment on attachment 241155 [details] Patch Clearing flags on attachment: 241155 Committed r175742: <http://trac.webkit.org/changeset/175742>
WebKit Commit Bot
Comment 6 2014-11-06 21:53:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.