Bug 138471

Summary:

Data detectors popover points at the first line of the detected item

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, bdakin, buildbot, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Description Tim Horton 2014-11-06 11:52:01 PST

Data detectors popover points at the first line of the detected item

Comment 1 Tim Horton 2014-11-06 11:52:14 PST

Created attachment 241121 [details]
Patch

Comment 2 Tim Horton 2014-11-06 11:53:12 PST

<rdar://problem/18893079>

Comment 3 Tim Horton 2014-11-06 11:53:38 PST

Comment on attachment 241121 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241121&action=review

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:1137
> +        detectedDataBoundingBox.unite(mainResultRange->ownerDocument().view()->contentsToWindow(quad.enclosingBoundingBox()));

Probably should keep the view around on the side...

Comment 4 Sam Weinig 2014-11-06 13:08:10 PST

Comment on attachment 241121 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241121&action=review

>> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:1137
>> +        detectedDataBoundingBox.unite(mainResultRange->ownerDocument().view()->contentsToWindow(quad.enclosingBoundingBox()));
> 
> Probably should keep the view around on the side...

Agreed.

Comment 5 Tim Horton 2014-11-06 13:35:33 PST

http://trac.webkit.org/changeset/175711