Bug 138471

Summary: Data detectors popover points at the first line of the detected item
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, buildbot, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Tim Horton
Reported 2014-11-06 11:52:01 PST
Data detectors popover points at the first line of the detected item
Attachments
Patch (1.90 KB, patch)
2014-11-06 11:52 PST, Tim Horton 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-11-06 11:52:14 PST
Created attachment 241121 [details] Patch
Tim Horton
Comment 2 2014-11-06 11:53:12 PST
<rdar://problem/18893079>
Tim Horton
Comment 3 2014-11-06 11:53:38 PST
Comment on attachment 241121 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241121&action=review > Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:1137 > + detectedDataBoundingBox.unite(mainResultRange->ownerDocument().view()->contentsToWindow(quad.enclosingBoundingBox())); Probably should keep the view around on the side...
Sam Weinig
Comment 4 2014-11-06 13:08:10 PST
Comment on attachment 241121 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241121&action=review >> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:1137 >> + detectedDataBoundingBox.unite(mainResultRange->ownerDocument().view()->contentsToWindow(quad.enclosingBoundingBox())); > > Probably should keep the view around on the side... Agreed.
Tim Horton
Comment 5 2014-11-06 13:35:33 PST
http://trac.webkit.org/changeset/175711
Note You need to log in before you can comment on or make changes to this bug.