Bug 138471 - Data detectors popover points at the first line of the detected item
Summary: Data detectors popover points at the first line of the detected item
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-06 11:52 PST by Tim Horton
Modified: 2014-11-06 13:35 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.90 KB, patch)
2014-11-06 11:52 PST, Tim Horton 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-11-06 11:52:01 PST 
Data detectors popover points at the first line of the detected item
Comment 1 Tim Horton 2014-11-06 11:52:14 PST 
Created attachment 241121 [details]
Patch
Comment 2 Tim Horton 2014-11-06 11:53:12 PST 
<rdar://problem/18893079>
Comment 3 Tim Horton 2014-11-06 11:53:38 PST 
Comment on attachment 241121 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241121&action=review

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:1137
> +        detectedDataBoundingBox.unite(mainResultRange->ownerDocument().view()->contentsToWindow(quad.enclosingBoundingBox()));

Probably should keep the view around on the side...
Comment 4 Sam Weinig 2014-11-06 13:08:10 PST 
Comment on attachment 241121 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241121&action=review

>> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:1137
>> +        detectedDataBoundingBox.unite(mainResultRange->ownerDocument().view()->contentsToWindow(quad.enclosingBoundingBox()));
> 
> Probably should keep the view around on the side...

Agreed.
Comment 5 Tim Horton 2014-11-06 13:35:33 PST 
http://trac.webkit.org/changeset/175711