Bug 138470

Summary:

Add test for fix of REGRESSION (r174985-174986): Site display disappears

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

WebCore JavaScript

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ggaren: review+

Michael Saboff

Reported 2014-11-06 11:48:59 PST

The patch was landed before a test was created.

Attachments
Patch (2.41 KB, patch) 2014-11-10 15:15 PST, Michael Saboff	ggaren: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Michael Saboff

Comment 1 2014-11-10 15:15:46 PST

Created attachment 241312 [details] Patch

Geoffrey Garen

Comment 2 2014-11-10 15:17:28 PST

Comment on attachment 241312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241312&action=review r=me > LayoutTests/js/dom/document-write-functions-cached.html:18 > +if (document.writeln === document.writeln) > + debug("PASS: document.write is cached."); > +else > + debug("FAIL: document.write is not cached, but should be."); Message should be writeln, not write.

Michael Saboff

Comment 3 2014-11-10 15:23:17 PST

(In reply to comment #2) > Comment on attachment 241312 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=241312&action=review > > r=me > > > LayoutTests/js/dom/document-write-functions-cached.html:18 > > +if (document.writeln === document.writeln) > > + debug("PASS: document.write is cached."); > > +else > > + debug("FAIL: document.write is not cached, but should be."); > > Message should be writeln, not write. Fixed.

Michael Saboff

Comment 4 2014-11-10 15:23:50 PST

Committed r175834: <http://trac.webkit.org/changeset/175834>

Note You need to log in before you can comment on or make changes to this bug.