Bug 138445

Summary: It should be possible to open a page preview by clicking on it
Product: WebKit Reporter: Conrad Shultz <conrad_shultz>
Component: WebKit2Assignee: Conrad Shultz <conrad_shultz>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, conrad_shultz, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+, thorton: commit-queue-

Conrad Shultz
Reported 2014-11-05 15:19:27 PST
It should be possible to open a page preview by clicking on it.
Attachments
Patch (5.84 KB, patch)
2014-11-05 15:33 PST, Conrad Shultz 		no flags
DetailsFormatted DiffDiff
Patch (5.99 KB, patch)
2014-11-05 15:43 PST, Conrad Shultz 		thorton: review+
thorton: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-11-05 15:20:25 PST
<rdar://problem/18887218>
Conrad Shultz
Comment 2 2014-11-05 15:33:42 PST
Created attachment 241065 [details] Patch
Conrad Shultz
Comment 3 2014-11-05 15:36:18 PST
Comment on attachment 241065 [details] Patch Will rebase and post a new patch.
Conrad Shultz
Comment 4 2014-11-05 15:43:21 PST
Created attachment 241067 [details] Patch
WebKit Commit Bot
Comment 5 2014-11-05 15:44:32 PST
Attachment 241067 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:351: The parameter name "pagePreviewViewController" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:815: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 6 2014-11-05 15:54:23 PST
http://trac.webkit.org/changeset/175646
Note You need to log in before you can comment on or make changes to this bug.