Bug 138445

Summary: It should be possible to open a page preview by clicking on it
Product: WebKit Reporter: Conrad Shultz <conrad_shultz>
Component: WebKit2Assignee: Conrad Shultz <conrad_shultz>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, conrad_shultz, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+, thorton: commit-queue-

Description Conrad Shultz 2014-11-05 15:19:27 PST 
It should be possible to open a page preview by clicking on it.
Comment 1 Radar WebKit Bug Importer 2014-11-05 15:20:25 PST 
<rdar://problem/18887218>
Comment 2 Conrad Shultz 2014-11-05 15:33:42 PST 
Created attachment 241065 [details]
Patch
Comment 3 Conrad Shultz 2014-11-05 15:36:18 PST 
Comment on attachment 241065 [details]
Patch

Will rebase and post a new patch.
Comment 4 Conrad Shultz 2014-11-05 15:43:21 PST 
Created attachment 241067 [details]
Patch
Comment 5 WebKit Commit Bot 2014-11-05 15:44:32 PST 
Attachment 241067 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:351:  The parameter name "pagePreviewViewController" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:815:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Tim Horton 2014-11-05 15:54:23 PST 
http://trac.webkit.org/changeset/175646