Bug 138445 - It should be possible to open a page preview by clicking on it
Summary: It should be possible to open a page preview by clicking on it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Conrad Shultz
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-11-05 15:19 PST by Conrad Shultz
Modified: 2014-11-05 15:54 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.84 KB, patch)
2014-11-05 15:33 PST, Conrad Shultz 		no flags Details | Formatted Diff | Diff
Patch (5.99 KB, patch)
2014-11-05 15:43 PST, Conrad Shultz 		thorton: review+
thorton: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad Shultz 2014-11-05 15:19:27 PST 
It should be possible to open a page preview by clicking on it.
Comment 1 Radar WebKit Bug Importer 2014-11-05 15:20:25 PST 
<rdar://problem/18887218>
Comment 2 Conrad Shultz 2014-11-05 15:33:42 PST 
Created attachment 241065 [details]
Patch
Comment 3 Conrad Shultz 2014-11-05 15:36:18 PST 
Comment on attachment 241065 [details]
Patch

Will rebase and post a new patch.
Comment 4 Conrad Shultz 2014-11-05 15:43:21 PST 
Created attachment 241067 [details]
Patch
Comment 5 WebKit Commit Bot 2014-11-05 15:44:32 PST 
Attachment 241067 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:351:  The parameter name "pagePreviewViewController" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:815:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Tim Horton 2014-11-05 15:54:23 PST 
http://trac.webkit.org/changeset/175646