Bug 138444

Summary: Page preview popover should show scaled-down web content
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, conrad_shultz, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Description Beth Dakin 2014-11-05 15:16:25 PST 
Page preview popover should show scaled-down web content

rdar://problem/18887140
Comment 1 Beth Dakin 2014-11-05 15:20:48 PST 
Created attachment 241062 [details]
Patch
Comment 2 Tim Horton 2014-11-05 15:22:24 PST 
Comment on attachment 241062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241062&action=review

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:63
> +static const CGFloat preferredPopoverToWKViewScale = 0.75;

It's not a WKView :)
Comment 3 Anders Carlsson 2014-11-05 15:27:23 PST 
Comment on attachment 241062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241062&action=review

>> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:63
>> +static const CGFloat preferredPopoverToWKViewScale = 0.75;
> 
> It's not a WKView :)

Nor preferred :)

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:110
> +    [webView setBounds:NSMakeRect(0, 0, _mainViewSize.width / preferredPopoverToWKViewScale, _mainViewSize.height / preferredPopoverToWKViewScale)];

This could probably use a comment.
Comment 4 Beth Dakin 2014-11-05 15:32:06 PST 
Thanks! http://trac.webkit.org/changeset/175645
Comment 5 Tim Horton 2014-11-05 16:19:46 PST 
Build fix in http://trac.webkit.org/changeset/175649