Bug 138428

Summary: [GTK] Run layout tests using the network process
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, clopez, commit-queue, gustavo, ossy
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 138460, 138500, 138501    
Bug Blocks:    
Attachments:
Description Flags
Patch mrobinson: review+

Description Carlos Garcia Campos 2014-11-05 09:14:28 PST
Shared secondary process is the default in the GTK+ port, but we should run the tests using the network process to ensure everything works with the network process. In the future, the shared secondary process model might be a special case of multiple processes with 1 as maximum number of processes, but always using the network process.
Comment 1 Carlos Garcia Campos 2014-11-05 09:16:19 PST
Created attachment 241031 [details]
Patch
Comment 2 Carlos Garcia Campos 2014-11-06 00:47:39 PST
Committed r175690: <http://trac.webkit.org/changeset/175690>
Comment 3 WebKit Commit Bot 2014-11-06 02:26:46 PST
Re-opened since this is blocked by bug 138460
Comment 4 Carlos Garcia Campos 2014-11-08 02:51:52 PST
Let's try again now :-)
Comment 5 Carlos Garcia Campos 2014-11-08 02:53:27 PST
Committed r175776: <http://trac.webkit.org/changeset/175776>
Comment 6 Carlos Garcia Campos 2014-11-08 03:50:10 PST
Ok, no more crashes, but there are still some more failures, most of them are http tests. I'll look at those in detail and will try to fix them without rolling this out again.
Comment 7 Carlos Alberto Lopez Perez 2014-11-08 11:29:54 PST
(In reply to comment #6)
> Ok, no more crashes, but there are still some more failures, most of them
> are http tests. I'll look at those in detail and will try to fix them
> without rolling this out again.

This (r175776) has caused +60 new failures: 

r175775 -> https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/4067

r175776 -> https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/4064
Comment 8 Alexey Proskuryakov 2014-11-08 20:29:20 PST
One big reason for these failures is that shared workers are disabled in multiple web process mode.

Another one that I'm particularly interested in is http/tests/xmlhttprequest/cross-origin-cookie-storage.html. It looks like I independently broke this test on Mac a few revisions later. We'll need to see what's going on there.
Comment 9 Alexey Proskuryakov 2014-11-08 22:34:24 PST
> Another one that I'm particularly interested in is
> http/tests/xmlhttprequest/cross-origin-cookie-storage.html.

Turns out that it's simply because testRunner.setAlwaysAcceptCookies is not implemented with NetworkProcess. The test used to pass on Mac by mistake, due to having a cookie leak from a previous test.

I disabled it on Mac.
Comment 10 Carlos Garcia Campos 2014-11-09 02:06:01 PST
(In reply to comment #7)
> (In reply to comment #6)
> > Ok, no more crashes, but there are still some more failures, most of them
> > are http tests. I'll look at those in detail and will try to fix them
> > without rolling this out again.
> 
> This (r175776) has caused +60 new failures: 

I know, and I said that I'll look at those in detail and I'll try to fix them without rolling it out. If I can't figure out how to fix the failures, I'll roll this out, don't worry.

> r175775 ->
> https://build.webkit.org/builders/GTK%20Linux%2064-
> bit%20Release%20%28Tests%29/builds/4067
> 
> r175776 ->
> https://build.webkit.org/builders/GTK%20Linux%2064-
> bit%20Release%20%28Tests%29/builds/4064
Comment 11 Carlos Garcia Campos 2014-11-12 06:23:55 PST
(In reply to comment #8)
> One big reason for these failures is that shared workers are disabled in
> multiple web process mode.

Thanks, I've just skipped the shared workers tests in r176019