Summary: | [GTK] Run layout tests using the network process | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, ap, clopez, commit-queue, gustavo, ossy | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 138460, 138500, 138501 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Carlos Garcia Campos
2014-11-05 09:14:28 PST
Created attachment 241031 [details]
Patch
Committed r175690: <http://trac.webkit.org/changeset/175690> Re-opened since this is blocked by bug 138460 Let's try again now :-) Committed r175776: <http://trac.webkit.org/changeset/175776> Ok, no more crashes, but there are still some more failures, most of them are http tests. I'll look at those in detail and will try to fix them without rolling this out again. (In reply to comment #6) > Ok, no more crashes, but there are still some more failures, most of them > are http tests. I'll look at those in detail and will try to fix them > without rolling this out again. This (r175776) has caused +60 new failures: r175775 -> https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/4067 r175776 -> https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/4064 One big reason for these failures is that shared workers are disabled in multiple web process mode. Another one that I'm particularly interested in is http/tests/xmlhttprequest/cross-origin-cookie-storage.html. It looks like I independently broke this test on Mac a few revisions later. We'll need to see what's going on there. > Another one that I'm particularly interested in is
> http/tests/xmlhttprequest/cross-origin-cookie-storage.html.
Turns out that it's simply because testRunner.setAlwaysAcceptCookies is not implemented with NetworkProcess. The test used to pass on Mac by mistake, due to having a cookie leak from a previous test.
I disabled it on Mac.
(In reply to comment #7) > (In reply to comment #6) > > Ok, no more crashes, but there are still some more failures, most of them > > are http tests. I'll look at those in detail and will try to fix them > > without rolling this out again. > > This (r175776) has caused +60 new failures: I know, and I said that I'll look at those in detail and I'll try to fix them without rolling it out. If I can't figure out how to fix the failures, I'll roll this out, don't worry. > r175775 -> > https://build.webkit.org/builders/GTK%20Linux%2064- > bit%20Release%20%28Tests%29/builds/4067 > > r175776 -> > https://build.webkit.org/builders/GTK%20Linux%2064- > bit%20Release%20%28Tests%29/builds/4064 (In reply to comment #8) > One big reason for these failures is that shared workers are disabled in > multiple web process mode. Thanks, I've just skipped the shared workers tests in r176019 |