Summary: | AX: Improve AccessibilityTableCell isColumnHeaderCell function. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrzej Badowski <a.badowski> | ||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Andrzej Badowski
2014-11-05 07:22:23 PST
Created attachment 241111 [details]
proposed patch
Comment on attachment 241111 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=241111&action=review > Source/WebCore/ChangeLog:10 > + New tests are not necessary. how come no new tests are necessary? Comment on attachment 241111 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=241111&action=review >> Source/WebCore/ChangeLog:10 >> + New tests are not necessary. > > how come no new tests are necessary? Existing tests: table-cells-roles.html, table-cells.html have improved -expected files. In these files are visible positive changes. Eg. For the test table-cells-roles. So far, according to the logic of two functions: isColumnHeaderCell and isRowHeaderCell, cell (2,0), while in tbody 0 row, shows the role of AXCell. After correcting, this cell in row 0 will be assigned the role of AXColumnHeader. Similarly, in the test table-cells. Comment on attachment 241111 [details] proposed patch Clearing flags on attachment: 241111 Committed r176122: <http://trac.webkit.org/changeset/176122> All reviewed patches have been landed. Closing bug. |