|Summary:||AX: Improve AccessibilityTableCell isColumnHeaderCell function.|
|Product:||WebKit||Reporter:||Andrzej Badowski <a.badowski>|
|Version:||528+ (Nightly build)|
Description Andrzej Badowski 2014-11-05 07:22:23 PST
The error in this function has been detected, when it turned out that the direct placement of <tr> tag to the <table> tage is changed in the browser. Namely, the resulting html code viewed by Inspector shows that between the <table> tag and the <tr> tag has been added <tbody> tag. Examples of browsers include: Mozilla, Chromium, Opera, Safari, MiniBrowser EFL. Function should take into account the behavior of browsers.
Comment 2 Andrzej Badowski 2014-11-06 08:52:31 PST
Created attachment 241111 [details] proposed patch
Comment 3 chris fleizach 2014-11-10 09:36:30 PST
Comment on attachment 241111 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=241111&action=review > Source/WebCore/ChangeLog:10 > + New tests are not necessary. how come no new tests are necessary?
Comment 4 Andrzej Badowski 2014-11-12 10:01:46 PST
Comment on attachment 241111 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=241111&action=review >> Source/WebCore/ChangeLog:10 >> + New tests are not necessary. > > how come no new tests are necessary? Existing tests: table-cells-roles.html, table-cells.html have improved -expected files. In these files are visible positive changes. Eg. For the test table-cells-roles. So far, according to the logic of two functions: isColumnHeaderCell and isRowHeaderCell, cell (2,0), while in tbody 0 row, shows the role of AXCell. After correcting, this cell in row 0 will be assigned the role of AXColumnHeader. Similarly, in the test table-cells.
Comment 5 WebKit Commit Bot 2014-11-14 03:27:53 PST
Comment on attachment 241111 [details] proposed patch Clearing flags on attachment: 241111 Committed r176122: <http://trac.webkit.org/changeset/176122>
Comment 6 WebKit Commit Bot 2014-11-14 03:27:56 PST
All reviewed patches have been landed. Closing bug.