| Summary: | Add cache coders | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
| Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, cgarcia, commit-queue, sam, syoichi | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 30322 | ||||||
| Attachments: |
|
||||||
|
Description
Antti Koivisto
2014-11-05 02:48:02 PST
Created attachment 241016 [details]
patch
Attachment 241016 [details] did not pass style-queue:
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:95: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:96: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:97: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:98: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:99: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:100: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:101: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:102: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:103: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheEncoder.h:104: More than one command on the same line [whitespace/newline] [4]
Total errors found: 10 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 241016 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=241016&action=review > Source/WebKit2/NetworkProcess/cache/NetworkCacheCoders.cpp:163 > + long long certificateSize; > + if (!decoder.decode(certificateSize)) This is long long, but there isn't a NetworkCacheDecoder::decode(long long&); Comment on attachment 241016 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=241016&action=review > Source/WebKit2/NetworkProcess/cache/NetworkCacheCoders.cpp:162 > + long long certificateSize; This should probably be int64_t. Comment on attachment 241016 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=241016&action=review > Source/WebKit2/NetworkProcess/cache/NetworkCacheCoders.cpp:156 > + encoder << static_cast<long long>(argumentEncoder.bufferSize()); And here too. |