| Summary: | Incorrect sandbox_check in RemoteInspector.mm | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
| Component: | Web Inspector | Assignee: | Alexey Proskuryakov <ap> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | buildbot, commit-queue, graouts, joepeck, rniwa, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 241006 [details]
proposed fix
Attachment 241006 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:61: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 241006 [details]
proposed fix
r=me
Comment on attachment 241006 [details] proposed fix Clearing flags on attachment: 241006 Committed r175629: <http://trac.webkit.org/changeset/175629> All reviewed patches have been landed. Closing bug. |
1. There is no SANDBOX_CHECK_NO_REPORT, so I think that this still generates a sandbox violation. 2. In open source builds, the value of SANDBOX_FILTER_GLOBAL_NAME is incorrect - it should be 2, not 0. enum sandbox_filter_type { SANDBOX_FILTER_GLOBAL_NAME, };