| Summary: | Add bundle SPI allowing PageOverlay to customize the action menu | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, bdakin, mitz, sam, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2014-11-04 17:25:03 PST
Created attachment 240988 [details]
Patch
Comment on attachment 240988 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240988&action=review > Source/WebCore/page/PageOverlayController.h:52 > + Vector<RefPtr<PageOverlay>>& pageOverlays() const { return m_pageOverlays; } This should either return a const Vector& or not be const. > Source/WebKit2/WebProcess/WebPage/WebPageOverlay.cpp:39 > +static HashMap<PageOverlay*, WebPageOverlay*>& coreOverlayMap() I think this can just be called overlayMap(). > Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:1205 > + for (auto& overlay : mainFrame.pageOverlayController().pageOverlays()) { I think this can be const auto&. |