Bug 138388

Summary: Add bundle SPI allowing PageOverlay to customize the action menu
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, mitz, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Tim Horton
Reported 2014-11-04 17:25:03 PST
Add bundle SPI allowing PageOverlay to customize the action menu
Attachments
Patch (14.80 KB, patch)
2014-11-04 17:25 PST, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-11-04 17:25:23 PST
Created attachment 240988 [details] Patch
Radar WebKit Bug Importer
Comment 2 2014-11-04 17:26:37 PST
<rdar://problem/18875579>
Anders Carlsson
Comment 3 2014-11-04 17:36:10 PST
Comment on attachment 240988 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240988&action=review > Source/WebCore/page/PageOverlayController.h:52 > + Vector<RefPtr<PageOverlay>>& pageOverlays() const { return m_pageOverlays; } This should either return a const Vector& or not be const. > Source/WebKit2/WebProcess/WebPage/WebPageOverlay.cpp:39 > +static HashMap<PageOverlay*, WebPageOverlay*>& coreOverlayMap() I think this can just be called overlayMap(). > Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:1205 > + for (auto& overlay : mainFrame.pageOverlayController().pageOverlays()) { I think this can be const auto&.
Tim Horton
Comment 4 2014-11-04 17:40:05 PST
http://trac.webkit.org/changeset/175597
Note You need to log in before you can comment on or make changes to this bug.