Bug 138387

Summary: Web Inspector: Lots of TimelineDataGridNode asserts on reloads
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: burg, commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2014-11-04 17:08:49 PST
* SUMMARY
Hundreds of of TimelineDataGridNode asserts reloading pages.

    console.assert(isFinite(secondsPerPixel) && secondsPerPixel > 0);

[Error] Assertion failed:
  refreshGraph (TimelineDataGridNode.js, line 240)
  updateLayout (OverviewTimelineView.js, line 110)
  updateLayoutIfNeeded (TimelineView.js, line 217)
  _updateTimes (TimelineContentView.js, line 367)
  _update (TimelineContentView.js, line 331)
  (anonymous function) ([native code], line 0)

* STEPS TO REPRODUCE
1. Inspect http://daringfireball.net
2. Ensure Resource sidebar is selected not Timelines. Close and reopen inspector if needed.
3. Reload page
  => hundreds of asserts

* NOTES
secondsPerPixel is 0.
Comment 1 Radar WebKit Bug Importer 2014-11-04 17:09:18 PST
<rdar://problem/18875354>
Comment 2 Joseph Pecoraro 2014-11-04 17:11:13 PST
Created attachment 240984 [details]
[PATCH] Proposed Fix
Comment 3 Brian Burg 2014-11-04 17:54:13 PST
Comment on attachment 240984 [details]
[PATCH] Proposed Fix

Another thought (maybe a different bug): why do we refresh the timeline ruler's layout when it's not visible? This seems like a lot of work for no reason.
Comment 4 Joseph Pecoraro 2014-11-04 18:22:30 PST
(In reply to comment #3)
> Comment on attachment 240984 [details]
> [PATCH] Proposed Fix
> 
> Another thought (maybe a different bug): why do we refresh the timeline
> ruler's layout when it's not visible? This seems like a lot of work for no
> reason.

Totally agree. I'll file a bug about that right now.
Comment 5 WebKit Commit Bot 2014-11-04 18:31:52 PST
Comment on attachment 240984 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 240984

Committed r175598: <http://trac.webkit.org/changeset/175598>
Comment 6 WebKit Commit Bot 2014-11-04 18:31:55 PST
All reviewed patches have been landed.  Closing bug.