| Summary: | Web Inspector: Lots of TimelineDataGridNode asserts on reloads | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | burg, commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 240984 [details]
[PATCH] Proposed Fix
Comment on attachment 240984 [details]
[PATCH] Proposed Fix
Another thought (maybe a different bug): why do we refresh the timeline ruler's layout when it's not visible? This seems like a lot of work for no reason.
(In reply to comment #3) > Comment on attachment 240984 [details] > [PATCH] Proposed Fix > > Another thought (maybe a different bug): why do we refresh the timeline > ruler's layout when it's not visible? This seems like a lot of work for no > reason. Totally agree. I'll file a bug about that right now. Comment on attachment 240984 [details] [PATCH] Proposed Fix Clearing flags on attachment: 240984 Committed r175598: <http://trac.webkit.org/changeset/175598> All reviewed patches have been landed. Closing bug. |
* SUMMARY Hundreds of of TimelineDataGridNode asserts reloading pages. console.assert(isFinite(secondsPerPixel) && secondsPerPixel > 0); [Error] Assertion failed: refreshGraph (TimelineDataGridNode.js, line 240) updateLayout (OverviewTimelineView.js, line 110) updateLayoutIfNeeded (TimelineView.js, line 217) _updateTimes (TimelineContentView.js, line 367) _update (TimelineContentView.js, line 331) (anonymous function) ([native code], line 0) * STEPS TO REPRODUCE 1. Inspect http://daringfireball.net 2. Ensure Resource sidebar is selected not Timelines. Close and reopen inspector if needed. 3. Reload page => hundreds of asserts * NOTES secondsPerPixel is 0.