Bug 138381

Summary: Disable flakey float32-repeat-out-of-bounds.js and int8-repeat-out-of-bounds.js tests for ARM64
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Updated patch mark.lam: review+

Michael Saboff
Reported 2014-11-04 15:46:30 PST
These tests are flakey when run on ARM64. These test will be disabled, fixed and then re-enabled. They die about half the time with output like: [2014-11-04 14:11:28] INFO: Running stress/float32-repeat-out-of-bounds.js.ftl-no-cjit-validate [2014-11-04 14:11:28] INFO: stress/float32-repeat-out-of-bounds.js.ftl-no-cjit-no-inline-validate: Exception: Error: unexpected retry count: 1 [2014-11-04 14:11:28] INFO: stress/float32-repeat-out-of-bounds.js.ftl-no-cjit-no-inline-validate: ERROR: Unexpected exit code: 3 and [2014-11-04 14:09:09] INFO: Running stress/int8-repeat-out-of-bounds.js.ftl-no-cjit-validate [2014-11-04 14:09:09] INFO: stress/int8-repeat-out-of-bounds.js.ftl-no-cjit-validate: Exception: Error: unexpected retry count: 1 [2014-11-04 14:09:09] INFO: stress/int8-repeat-out-of-bounds.js.ftl-no-cjit-validate: ERROR: Unexpected exit code: 3
Attachments
Patch (1.64 KB, patch)
2014-11-04 15:48 PST, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Updated patch (1.83 KB, patch)
2014-11-05 15:17 PST, Michael Saboff 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2014-11-04 15:48:25 PST
Created attachment 240970 [details] Patch
Mark Lam
Comment 2 2014-11-04 16:09:14 PST
Comment on attachment 240970 [details] Patch r=me
WebKit Commit Bot
Comment 3 2014-11-04 16:29:16 PST
Comment on attachment 240970 [details] Patch Clearing flags on attachment: 240970 Committed r175587: <http://trac.webkit.org/changeset/175587>
WebKit Commit Bot
Comment 4 2014-11-04 16:29:19 PST
All reviewed patches have been landed. Closing bug.
Geoffrey Garen
Comment 5 2014-11-04 17:03:54 PST
Can you file a follow-up bug and mention it here in this bug report?
Michael Saboff
Comment 6 2014-11-04 17:28:27 PST
Bug to fix the tests is <https://bugs.webkit.org/show_bug.cgi?id=138391> - "Fix flakey float32-repeat-out-of-bounds.js and int8-repeat-out-of-bounds.js tests for ARM64"
Michael Saboff
Comment 7 2014-11-05 15:16:31 PST
Original change didn't disable the tests.
Michael Saboff
Comment 8 2014-11-05 15:17:41 PST
Created attachment 241060 [details] Updated patch
Mark Lam
Comment 9 2014-11-05 15:19:30 PST
Comment on attachment 241060 [details] Updated patch rs=me
Michael Saboff
Comment 10 2014-11-05 15:20:20 PST
Committed r175644: <http://trac.webkit.org/changeset/175644>
Note You need to log in before you can comment on or make changes to this bug.