Bug 138377

Summary: Remove two unused ScrollingCoordinator methods.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, jamesr, kling, luiz, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch II cdumez: review+

Andreas Kling
Reported 2014-11-04 15:03:19 PST
These functions appear to be unused: scrollLayerForScrollableArea horizontalScrollbarLayerForScrollableArea verticalScrollbarLayerForScrollableArea
Attachments
Patch (2.71 KB, patch)
2014-11-04 15:03 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch II (2.40 KB, patch)
2014-11-04 15:08 PST, Andreas Kling 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-11-04 15:03:46 PST
Created attachment 240954 [details] Patch
Chris Dumez
Comment 2 2014-11-04 15:06:17 PST
Comment on attachment 240954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240954&action=review > Source/WebCore/page/scrolling/ScrollingCoordinator.h:-211 > - static GraphicsLayer* scrollLayerForScrollableArea(ScrollableArea*); Isn't this used for CoordinatedGraphics? Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp
Andreas Kling
Comment 3 2014-11-04 15:07:04 PST
(In reply to comment #2) > Comment on attachment 240954 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240954&action=review > > > Source/WebCore/page/scrolling/ScrollingCoordinator.h:-211 > > - static GraphicsLayer* scrollLayerForScrollableArea(ScrollableArea*); > > Isn't this used for CoordinatedGraphics? > Source/WebCore/page/scrolling/coordinatedgraphics/ > ScrollingCoordinatorCoordinatedGraphics.cpp Whoops! Right you are.
Andreas Kling
Comment 4 2014-11-04 15:08:50 PST
Created attachment 240955 [details] Patch II
Chris Dumez
Comment 5 2014-11-04 15:09:19 PST
Comment on attachment 240955 [details] Patch II r=me
Andreas Kling
Comment 6 2014-11-04 15:14:25 PST
Committed r175584: <http://trac.webkit.org/changeset/175584>
Note You need to log in before you can comment on or make changes to this bug.