Bug 138367

Summary:

RenderBox shouldn't need a pre-destructor hook.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Andreas Kling 2014-11-04 13:04:12 PST

RenderBox::willBeDestroyed() does a couple of things, but none of them require the renderer to be in-tree, nor does it do any virtual dispatch.
We should move the logic to the plain destructor and get rid of the hook.

Comment 1 Andreas Kling 2014-11-04 13:05:37 PST

Created attachment 240942 [details]
Patch

Comment 2 WebKit Commit Bot 2014-11-04 14:16:47 PST

Comment on attachment 240942 [details]
Patch

Clearing flags on attachment: 240942

Committed r175580: <http://trac.webkit.org/changeset/175580>

Comment 3 WebKit Commit Bot 2014-11-04 14:16:51 PST

All reviewed patches have been landed.  Closing bug.