Bug 138353

Summary: Dictionary lookup panel pops up at random when clicking on selected text
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kling: review+

Description Tim Horton 2014-11-03 23:28:32 PST
Dictionary lookup panel pops up at random when clicking on selected text
Comment 1 Tim Horton 2014-11-03 23:29:35 PST
Created attachment 240915 [details]
Patch
Comment 2 Tim Horton 2014-11-03 23:31:30 PST
Created attachment 240916 [details]
Patch
Comment 3 Tim Horton 2014-11-03 23:31:50 PST
<rdar://problem/18861406>
Comment 4 Andreas Kling 2014-11-03 23:44:27 PST
Comment on attachment 240916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240916&action=review

r=me

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:525
> +static PassRefPtr<Range> rangeForDictionaryLookupForSelection(Frame* frame, const VisibleSelection& selection, NSDictionary **options)

'frame' is not used for anything here.
Comment 5 Tim Horton 2014-11-03 23:45:15 PST
Comment on attachment 240916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240916&action=review

>> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:525
>> +static PassRefPtr<Range> rangeForDictionaryLookupForSelection(Frame* frame, const VisibleSelection& selection, NSDictionary **options)
> 
> 'frame' is not used for anything here.

Quite! Thanks for your review.
Comment 6 Tim Horton 2014-11-04 00:05:41 PST
http://trac.webkit.org/changeset/175517
Comment 7 Tim Horton 2014-11-04 00:20:58 PST
Follow up fix in http://trac.webkit.org/changeset/175524