Summary: | Dictionary lookup panel pops up at random when clicking on selected text | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, bdakin, sam, simon.fraser | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tim Horton
2014-11-03 23:28:32 PST
Created attachment 240915 [details]
Patch
Created attachment 240916 [details]
Patch
Comment on attachment 240916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240916&action=review r=me > Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:525 > +static PassRefPtr<Range> rangeForDictionaryLookupForSelection(Frame* frame, const VisibleSelection& selection, NSDictionary **options) 'frame' is not used for anything here. Comment on attachment 240916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240916&action=review >> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:525 >> +static PassRefPtr<Range> rangeForDictionaryLookupForSelection(Frame* frame, const VisibleSelection& selection, NSDictionary **options) > > 'frame' is not used for anything here. Quite! Thanks for your review. Follow up fix in http://trac.webkit.org/changeset/175524 |