Bug 138353

Summary: Dictionary lookup panel pops up at random when clicking on selected text
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kling: review+

Tim Horton
Reported 2014-11-03 23:28:32 PST
Dictionary lookup panel pops up at random when clicking on selected text
Attachments
Patch (7.06 KB, patch)
2014-11-03 23:29 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (7.24 KB, patch)
2014-11-03 23:31 PST, Tim Horton 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-11-03 23:29:35 PST
Created attachment 240915 [details] Patch
Tim Horton
Comment 2 2014-11-03 23:31:30 PST
Created attachment 240916 [details] Patch
Tim Horton
Comment 3 2014-11-03 23:31:50 PST
<rdar://problem/18861406>
Andreas Kling
Comment 4 2014-11-03 23:44:27 PST
Comment on attachment 240916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240916&action=review r=me > Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:525 > +static PassRefPtr<Range> rangeForDictionaryLookupForSelection(Frame* frame, const VisibleSelection& selection, NSDictionary **options) 'frame' is not used for anything here.
Tim Horton
Comment 5 2014-11-03 23:45:15 PST
Comment on attachment 240916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240916&action=review >> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:525 >> +static PassRefPtr<Range> rangeForDictionaryLookupForSelection(Frame* frame, const VisibleSelection& selection, NSDictionary **options) > > 'frame' is not used for anything here. Quite! Thanks for your review.
Tim Horton
Comment 6 2014-11-04 00:05:41 PST
http://trac.webkit.org/changeset/175517
Tim Horton
Comment 7 2014-11-04 00:20:58 PST
Follow up fix in http://trac.webkit.org/changeset/175524
Note You need to log in before you can comment on or make changes to this bug.