Bug 138351

Summary: Add button and enable optimized fullscreen.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, eric.carlson, jer.noble, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Jeremy Jones
Reported 2014-11-03 22:23:47 PST
Add button and enable optimized fullscreen.
Attachments
Patch (24.94 KB, patch)
2014-11-03 23:04 PST, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch (25.29 KB, patch)
2014-11-04 11:44 PST, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch (25.35 KB, patch)
2014-11-04 13:07 PST, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch (26.03 KB, patch)
2014-11-04 15:41 PST, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2014-11-03 22:24:48 PST
rdar://problem/18518262
Jeremy Jones
Comment 2 2014-11-03 23:04:26 PST
Created attachment 240914 [details] Patch
Eric Carlson
Comment 3 2014-11-04 08:11:19 PST
Comment on attachment 240914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240914&action=review You might want to put the WKSI parts, along with an updated library, into a separate patch. > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:330 > + if (event.scale > 1.2 || event.scale < 0.8) Nit: these should be constants > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:343 > + if (velocity < 2 || event.scale < 1.25) Ditto. > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:366 > + if (now - this.lastDoubleTouchTime < 300) { Ditto.
Jeremy Jones
Comment 4 2014-11-04 11:44:51 PST
Created attachment 240936 [details] Patch
Jeremy Jones
Comment 5 2014-11-04 13:07:08 PST
Created attachment 240943 [details] Patch
Jeremy Jones
Comment 6 2014-11-04 15:41:22 PST
Created attachment 240967 [details] Patch
Jeremy Jones
Comment 7 2014-11-04 16:45:54 PST
(In reply to comment #3) > Comment on attachment 240914 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240914&action=review > > You might want to put the WKSI parts, along with an updated library, into a > separate patch. WKSI checked in. > > > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:330 > > + if (event.scale > 1.2 || event.scale < 0.8) > > Nit: these should be constants Done > > > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:343 > > + if (velocity < 2 || event.scale < 1.25) > > Ditto. Done. > > > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:366 > > + if (now - this.lastDoubleTouchTime < 300) { > > Ditto. Done.
Jeremy Jones
Comment 8 2014-11-04 17:37:02 PST
Committed r175596
Jon Lee
Comment 9 2014-12-03 11:40:20 PST
Comment on attachment 240967 [details] Patch Removing r? to remove from the review queue
Note You need to log in before you can comment on or make changes to this bug.