Summary: | Implement yellow highlight over data detected items | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||
Component: | WebKit2 | Assignee: | Tim Horton <thorton> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | andersca, bdakin, buildbot, commit-queue, conrad_shultz, mitz, rniwa, sam, simon.fraser | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Tim Horton
2014-11-03 17:35:16 PST
Created attachment 240887 [details]
patch
Created attachment 240889 [details]
rebase
Attachment 240889 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:357: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 26 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Andersca sez "use unique_ptr for TextIndicator" and "make sure there's not a refcycle with the completion block". Created attachment 240903 [details]
patch
un-did the un-refcounting of TextIndicator; we can switch to unique_ptr later if we want.
Attachment 240903 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:358: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
|