Bug 138340

Summary: Implement yellow highlight over data detected items
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, buildbot, commit-queue, conrad_shultz, mitz, rniwa, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
rebase
none
patch andersca: review+

Tim Horton
Reported 2014-11-03 17:35:16 PST
<rdar://problem/18840102>
Attachments
patch (66.60 KB, patch)
2014-11-03 17:36 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
rebase (66.55 KB, patch)
2014-11-03 17:40 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
patch (58.54 KB, patch)
2014-11-03 20:10 PST, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-11-03 17:36:16 PST
Created attachment 240887 [details] patch
Tim Horton
Comment 2 2014-11-03 17:40:05 PST
Created attachment 240889 [details] rebase
WebKit Commit Bot
Comment 3 2014-11-03 17:41:25 PST
Attachment 240889 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:357: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 4 2014-11-03 18:15:29 PST
Andersca sez "use unique_ptr for TextIndicator" and "make sure there's not a refcycle with the completion block".
Tim Horton
Comment 5 2014-11-03 20:10:01 PST
Created attachment 240903 [details] patch un-did the un-refcounting of TextIndicator; we can switch to unique_ptr later if we want.
WebKit Commit Bot
Comment 6 2014-11-03 20:13:02 PST
Attachment 240903 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:358: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 7 2014-11-04 11:43:09 PST
http://trac.webkit.org/changeset/175564
Tim Horton
Comment 8 2014-11-04 12:46:00 PST
And http://trac.webkit.org/changeset/175568
Note You need to log in before you can comment on or make changes to this bug.