| Summary: | Fix jquery/manipulation.html flakiness on debug builds | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | Tools / Tests | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, barraclough, commit-queue, kling, koivisto, simon.fraser | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 138262 | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2014-11-03 16:39:17 PST
Created attachment 240882 [details]
Patch
Comment on attachment 240882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240882&action=review > LayoutTests/ChangeLog:13 > + throttled after r138262. This patch makes sense, but this test has been timing out in debug for a very long time, wasn't it? Also the revision number is wrong. Created attachment 240888 [details]
Patch
Comment on attachment 240888 [details] Patch Clearing flags on attachment: 240888 Committed r175504: <http://trac.webkit.org/changeset/175504> All reviewed patches have been landed. Closing bug. This test is still timing out in debug builds, e.g. https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20(Tests)/r175699%20(337)/results.html (In reply to comment #6) > This test is still timing out in debug builds, e.g. > https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20(Tests)/ > r175699%20(337)/results.html Ok, the test is slow in debug so this is not very surprising. However, timer throttling is no longer making it more flakier than it was (as a matter of fact, my timer throttling patch was recently reverted so it cannot be the source of the flakiness). We should just mark this test as flaky (maybe marking it as slow would suffice?). |