Bug 138335 – Fix jquery/manipulation.html flakiness on debug builds

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Chris Dumez]

jquery/manipulation.html is flaky on Debug builds.

[Chris Dumez]

Created attachment 240882 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 240882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240882&action=review

> LayoutTests/ChangeLog:13
> +        throttled after r138262.

This patch makes sense, but this test has been timing out in debug for a very long time, wasn't it?

Also the revision number is wrong.

[Chris Dumez]

Created attachment 240888 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 240888 [details]
Patch

Clearing flags on attachment: 240888

Committed r175504: <http://trac.webkit.org/changeset/175504>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

This test is still timing out in debug builds, e.g. https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20(Tests)/r175699%20(337)/results.html

[Chris Dumez]

(In reply to comment #6)
> This test is still timing out in debug builds, e.g.
> https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20(Tests)/
> r175699%20(337)/results.html

Ok, the test is slow in debug so this is not very surprising. However, timer throttling is no longer making it more flakier than it was (as a matter of fact, my timer throttling patch was recently reverted so it cannot be the source of the flakiness). We should just mark this test as flaky (maybe marking it as slow would suffice?).