Bug 138335 - Fix jquery/manipulation.html flakiness on debug builds
Summary: Fix jquery/manipulation.html flakiness on debug builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 138262
  Show dependency tree / graph
 
Reported: 2014-11-03 16:39 PST by Chris Dumez
Modified: 2014-11-06 12:14 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.43 KB, patch)
2014-11-03 16:53 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.43 KB, patch)
2014-11-03 17:39 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-11-03 16:39:17 PST 
jquery/manipulation.html is flaky on Debug builds.
Comment 1 Chris Dumez 2014-11-03 16:53:10 PST 
Created attachment 240882 [details]
Patch
Comment 2 Alexey Proskuryakov 2014-11-03 17:35:33 PST 
Comment on attachment 240882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240882&action=review

> LayoutTests/ChangeLog:13
> +        throttled after r138262.

This patch makes sense, but this test has been timing out in debug for a very long time, wasn't it?

Also the revision number is wrong.
Comment 3 Chris Dumez 2014-11-03 17:39:09 PST 
Created attachment 240888 [details]
Patch
Comment 4 WebKit Commit Bot 2014-11-03 18:23:45 PST 
Comment on attachment 240888 [details]
Patch

Clearing flags on attachment: 240888

Committed r175504: <http://trac.webkit.org/changeset/175504>
Comment 5 WebKit Commit Bot 2014-11-03 18:23:50 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Alexey Proskuryakov 2014-11-06 12:05:45 PST 
This test is still timing out in debug builds, e.g. https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20(Tests)/r175699%20(337)/results.html
Comment 7 Chris Dumez 2014-11-06 12:14:15 PST 
(In reply to comment #6)
> This test is still timing out in debug builds, e.g.
> https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20(Tests)/
> r175699%20(337)/results.html

Ok, the test is slow in debug so this is not very surprising. However, timer throttling is no longer making it more flakier than it was (as a matter of fact, my timer throttling patch was recently reverted so it cannot be the source of the flakiness). We should just mark this test as flaky (maybe marking it as slow would suffice?).