Bug 138316

Summary: RenderCounter shouldn't need a pre-destructor hook.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kling, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2014-11-03 10:37:46 PST
RenderCounter has a willBeDestroyed() hook, but it doesn't actually need it. It was done that way originally because there were no guarantees about calling RenderObject::view() in a renderer destructor. These days that's not a problem. Even if you are the RenderView. For real.
Attachments
Patch (2.22 KB, patch)
2014-11-03 10:54 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-11-03 10:54:57 PST
Created attachment 240863 [details] Patch
WebKit Commit Bot
Comment 2 2014-11-03 12:17:39 PST
Comment on attachment 240863 [details] Patch Clearing flags on attachment: 240863 Committed r175485: <http://trac.webkit.org/changeset/175485>
WebKit Commit Bot
Comment 3 2014-11-03 12:17:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.