Bug 138316

Summary:

RenderCounter shouldn't need a pre-destructor hook.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kling, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Andreas Kling 2014-11-03 10:37:46 PST

RenderCounter has a willBeDestroyed() hook, but it doesn't actually need it.
It was done that way originally because there were no guarantees about calling RenderObject::view() in a renderer destructor.
These days that's not a problem. Even if you are the RenderView. For real.

Comment 1 Andreas Kling 2014-11-03 10:54:57 PST

Created attachment 240863 [details]
Patch

Comment 2 WebKit Commit Bot 2014-11-03 12:17:39 PST

Comment on attachment 240863 [details]
Patch

Clearing flags on attachment: 240863

Committed r175485: <http://trac.webkit.org/changeset/175485>

Comment 3 WebKit Commit Bot 2014-11-03 12:17:43 PST

All reviewed patches have been landed.  Closing bug.